Build the wrapper job with Maven 4.0.0-rc-6 - #12675
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
The version bump from rc-5 to rc-6 is correct — Maven 4.0.0-rc-6 is a valid released version available on official Maven Central (confirmed HTTP 200 on repo.maven.apache.org).
However, CI is currently broken because the workflow's MVNW_REPOURL environment variable (line 40 of .github/workflows/maven.yml) directs the Maven wrapper to download from Google's Maven Central mirror (maven-central.storage-download.googleapis.com), which has not yet synced rc-6 (HTTP 404 confirmed). The previous version rc-5 is available on that mirror (HTTP 200 confirmed).
This sync gap has persisted for 5 days since the rc-6 release on 2026-07-30. The companion PR #12674 targeting master has the same CI failure.
This PR cannot pass CI until either:
- (a) the Google mirror syncs rc-6, or
- (b) the
MVNW_REPOURLis changed to point at official Maven Central for this version.
If the Google mirror continues to lag on RC artifacts, the project may need to investigate whether this mirror is appropriate for pre-GA versions.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
MVNW_REPOURL pointed the wrapper at the Google Cloud mirror of Central, which lags a fresh release: apache-maven-4.0.0-rc-6-bin.zip is a 404 there while Central already serves it, so the initial-build job dies with wget: Failed to fetch https://maven-central.storage-download.googleapis.com/maven2/org/apache/maven/apache-maven/4.0.0-rc-6/apache-maven-4.0.0-rc-6-bin.zip Unsetting MVNW_REPOURL makes the wrapper fetch from Central, which always has the version this workflow just asked for. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
LGTM ✅ — Re-reviewed after new commit. The second commit directly addresses the CI failure flagged in the previous review by removing MVNW_REPOURL so the wrapper downloads from official Central instead of the Google mirror that hadn't synced rc-6.
Key observations:
- The fix is identical to companion PR #12674 (master), keeping both target branches in sync.
- The Mimir session mirror for dependency resolution is correctly left unchanged — build dependencies are stable releases already synced to the mirror.
- The explanatory comment added to the workflow is clear and accurate.
- The version bump to rc-6 and the mirror fix are both correct.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
The mimir session pointed dependency resolution at the same Google Cloud mirror the wrapper used, and that mirror lags a fresh release: rc-6 artifacts were still 404 there days after Central served them. Commented out rather than deleted, so restoring the mirror is one line if its sync latency stops being a problem. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Restoring the Google Cloud mirror should be uncommenting one line, not recovering it from history, if its sync latency ever stops being a problem. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
LGTM ✅ — Re-reviewed after third commit. The new commit logically completes the mirror fix by commenting out the Mimir session mirror for dependency resolution — since Maven is building itself, rc-6 artifacts must also be resolvable from Central.
Key observations:
- Commit 2 fixed the wrapper download path; commit 3 fixes the dependency resolution path. Both address the same root cause (Google Cloud mirror lagging fresh releases).
- Commenting out rather than deleting is the right approach — easy rollback.
- Minor: file still lacks a trailing newline (pre-existing).
- Companion PR #12674 (master) shows the identical diff, keeping both branches in sync.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
2 participants
4.0.0-rc-6 is released; this points the wrapper job at it.
Note: the fork has Actions disabled, so this could not be pre-verified there — it relies on ASF CI.